13 May, 2016
1 commit
-
test/py raises an error, if a board has not enabled bdi command
> pytest.skip('bdinfo command not supported')
E NameError: global name 'pytest' is not definedimport pytest in test/py/u_boot_utils.py fixes this.
Signed-off-by: Heiko Schocher
Reviewed-by: Stephen Warren
06 May, 2016
1 commit
-
It can take a while for a host machine to notice that a USB device has
disconnected, and process the change. At the end of the DFU test, we wait
up to 10 seconds for this to happen. This change makes the test wait the
same (up to) 10 seconds at the start of the test for any previously active
USB device-mode session to be cleaned up. Such as session might have been
used to download U-Boot into memory for example; this is certainly true
on my Tegra test systems. This changes should solve the DFU test
intermittency issues I've been seeing on some Tegra devices.Signed-off-by: Stephen Warren
25 Apr, 2016
3 commits
-
After concatenation of "dfu_alt_info" variable from "dfu_alt_boot" and
"dfu_alt_system" it may happen that test and dummy files alt settings
are different than default 0 and 1.This patch provides the ability to set different values for them.
Signed-off-by: Lukasz Majewski
Acked-by: Stephen Warren
---
Changes for v3:
- replace variables declarations with ones read from configuration file
- remove not necessary str() conversion at DFU host command generationChanges for v2:
- generate "alt_info" automatically
- use file names as alt settings instead of numerical values
- extend in-code documentation -
By default (on almost all systems) the dfu env variable, which defines
available alt settings, is named as "dfu_alt_info".However on some platforms (i.e. Odroid XU3), the 'dfu_alt_info' is concatenated
from other variables - namely 'dfu_alt_boot' and 'dfu_alt_system' at run time
(when one types 'dfu 0 mmc 0' for first time).'dfu_alt_boot' describes alt settings which depend on boot medium - for example
boot loader's LBA sectors which are different on eMMC and SD card because of e.g.
MBR/GPT.'dfu_alt_system' describes board agnostic alt settings - like rootfs, kernel.
On such system we can only append/modify this env variable.Because of the above, we must have way to modify other than "dfu_ale_info"
variable to perform tests.Signed-off-by: Lukasz Majewski
Acked-by: Stephen Warren
---
Changes for v3:
- NoneChanges for v2:
- Rewrite of "alt_info_env_name" variable description
- Use of get() method on python's dictionary to easily obtain default
value -
This patch replaces hardcoded (i.e. 0 and 1) values passed to dfu_{read|write}
with variables.Signed-off-by: Lukasz Majewski
Acked-by: Stephen Warren
---
Changes for v3:
- Replace per module global variables with ones defined inside a function
Changes for v2:
- None
15 Apr, 2016
1 commit
-
LLVM 3.5 noted:
test/dm/core.c:41:35: warning: unused variable 'test_pdata_pre_reloc' [-Wunused-const-variable]
static const struct dm_test_pdata test_pdata_pre_reloc = {And the correct fix here is that the driver_info_pre_reloc test should
use the test_pdata_pre_reloc not test_pdata_manual variableCc: Simon Glass
Signed-off-by: Tom Rini
Reviewed-by: Simon Glass
12 Apr, 2016
3 commits
-
When implementing test/py hook scripts, it's helpful to read some working
examples. Provide a link to some. The link was mentioned in the commit
message which first added test/py, but not in any documentation file.Suggested-by: Lukasz Majewski
Signed-off-by: Stephen Warren
Reviewed-by: Tom Rini -
For example this setting:
env__net_tftp_readable_file = {
"fn": "ep108/image.ub",
"addr": 0x10000000,
"size": 25846296,
"crc32": "b726f9de",
}Signed-off-by: Michal Simek
Acked-by: Stephen Warren -
This shows more output, such as the internal output generated by the unit
test ("ut") command, which makes it easier to debug issues.Signed-off-by: Stephen Warren
Reviewed-by: Tom Rini
Reviewed-by: Simon Glass
02 Apr, 2016
1 commit
-
This patch adds emulated spmi bus controller with part of
pm8916 pmic on it to sandbox and tests validating SPMI uclass.Signed-off-by: Mateusz Kulikowski
Reviewed-by: Simon Glass
18 Mar, 2016
1 commit
-
Add some tests to check that block devices work as expected.
Signed-off-by: Simon Glass
Tested-by: Stephen Warren
15 Mar, 2016
4 commits
-
The USB subsystem has a few counters that need to be reset since they are
stored in static variables rather than driver-model data. An example is
usb_max_devs. Ultimately we should move this data into the USB uclass.For now, make sure that USB is reset after each test, so that the counters
go back to zero.Note: this is not a perfect solution: It a USB test fails it will exit
immediately and leave USB un-reset. The impact here is that it may cause
subsequence test failures in the same run.Signed-off-by: Simon Glass
-
To ease conversion to driver model, add helper functions which deal with
calling each block device method. With driver model we can reimplement these
functions with the same arguments.Use inline functions to avoid increasing code size on some boards.
Signed-off-by: Simon Glass
Reviewed-by: Bin Meng
Tested-by: Stephen Warren -
The current name is too generic. The function returns a block device based
on a provided string. Rename it to aid searching and make its purpose
clearer. Also add a few comments.Signed-off-by: Simon Glass
Reviewed-by: Bin Meng
Tested-by: Stephen Warren -
Use 'struct' instead of a typdef. Also since 'struct block_dev_desc' is long
and causes 80-column violations, rename it to struct blk_desc.Signed-off-by: Simon Glass
Reviewed-by: Bin Meng
Tested-by: Stephen Warren
26 Feb, 2016
5 commits
-
These are working correctly again, so re-enable them.
Signed-off-by: Simon Glass
Reviewed-by: Jagan Teki
Tested-by: Jagan Teki -
The awk tool can be confused by return character (ASCII 13) in its input
since it thinks there is a separate field. These can appear if the terminal
is in raw mode, perhaps due to a previous U-Boot crash with sandbox. This
is very confusing. Remove these so that the trace test passes.Signed-off-by: Simon Glass
-
When used with a device tree, sandbox now requires a 'reset' controller. Add
this to the device trees so that reset works and the tests can complete.Signed-off-by: Simon Glass
Fixes: 5010d98f (sandbox: Use the reset driver to handle reset) -
test_hush_if_test.py executes commands that require large values of
CONFIG_SYS_MAXARGS. Detect cases where the configured value is too low
and skip those tests.Ideally, this would be implemented inside console.run_command(). However,
the command passed to that function is already a completely formed string,
and determining its argument count usage would require splitting commands
at ;, handling quoting to deal with arguments containing spaces, etc. Even
passing the command as a list wouldn't solve all these issues, since we'd
still need to split commands on ; and deal with cases like "if test ..."
which consumes 0 of the argument count.Signed-off-by: Stephen Warren
Acked-by: Simon Glass -
Sending CTRL-C to QEMU's stdin aborts the process, even if stdin is being
used as a serial port (at least in the raspi2 machine with "qemu -serial
stdin"). Avoid sending CTRL-C to U-Boot to prevent it exiting.I'd originally used CTRL-C to make sure that if the character used to
abort autoboot ended up being treated as part of a command as well, it'd
abort command entry and return the prompt to a known state. However, this
is not needed, since aborting the autoboot eats the character used to do
that.Signed-off-by: Stephen Warren
Acked-by: Simon Glass
25 Feb, 2016
2 commits
-
Provide user option to skip SPL signature verification for cases where
u-boot is build with SPL support but full U-Boot is also verified
without SPL.If you want to support this feature please add env__spl_skipped = True
to your boardenv configuration file.For example Xilinx Zynq is using this feature where the same U-Boot
binary is checked with SPL and without SPL(with FSBL).Signed-off-by: Michal Simek
-
check for U-Boot SPL signature only if SPL really has a serial output.
So check if CONFIG_SPL_SERIAL_SUPPORT is active in board config.Signed-off-by: Heiko Schocher
Tested-by: Stephen Warren
Reviewed-by: Stephen Warren
16 Feb, 2016
7 commits
-
The initial boot of U-Boot happens within the context of the first test
that needs to access the U-Boot console when there is no existing
connection. This keeps all activity nestled within test execution, which
fits well into the pytest model. However, this mingles the U-Boot startup
logs with the execution of some test(s), which hides find the boundary
between the two.To solve this, wrap the "Starting U-Boot" logic into a separate log
section. If the user wishes, they can simply collapse this log section
when viewing the HTML log, to concentrate purely on the test's own
interaction.Signed-off-by: Stephen Warren
Acked-by: Simon Glass -
u_boot_console.exec_attach.get_spawn() performs two steps:
1) Spawn a process to communicate with the serial console.
2) Reset the board so that U-Boot starts running from scratch.Currently, if an exception happens in step (2), no cleanup is performed on
the process created in step (1). That process stays running and may e.g.
hold serial port locks, or simply continue to read data from the serial
port, thus preventing it from reaching any other process that attempts to
read from the same serial port later. While there is error cleanup code in
u_boot_console_base.ensure_spawned(), this is not triggered since the
exception prevents assignment to self.p there, and hence the exception
handler has no object to operate upon in cleanup_spawn().Solve this by enhancing u_boot_console.exec_attach.get_spawn() to clean
up any objects it has created.In theory, u_boot_spawn.Spawn's constructor has a similar issue, so fix
this too.Signed-off-by: Stephen Warren
Acked-by: Simon Glass -
Use lists rather than sets to record the status of tests. This causes
the test summary in the HTML file to be generated in the same order as
the tests are (or would have been) run. This makes it easier to locate
the first failed test. The log for this test might have interesting
first clues re: interaction with the environment (e.g. hardware flashing,
serial console, ...) and may help tracking down external issues.Signed-off-by: Stephen Warren
Acked-by: Simon Glass -
The Python ini file parser that's used to parse .config converts all keys
to lower-case. Hence, all queries against the results must use lower-case.
Fix u_boot_console.ensure_spawned() to test CONFIG_SPL correctly, or the
connection will fail for boards that have SPL.Signed-off-by: Stephen Warren
Acked-by: Simon Glass -
The code replaced pexpect with custom code long ago. Don't import the
unused module so it doesn't need to be installed.Signed-off-by: Stephen Warren
Acked-by: Simon Glass -
Add documentation describing the new --gdbserver feature, and some common
pytest options.Signed-off-by: Stephen Warren
Acked-by: Simon Glass -
Invoke each "ut"-based unit test as a separate pytest.
Now that the DM unit test runs under test/py, remove the manual shell
script that invokes it.Signed-off-by: Stephen Warren
Acked-by: Simon Glass
Tested-by: Simon Glass # v2, on sandbox
10 Feb, 2016
4 commits
-
The existing regex simply ensures that the captured version string doesn't
go past the end of a line. We really want to grab as much as possible. Do
this by explicitly including a ) character at the end of the regex to
match the last character of the version test.Signed-off-by: Stephen Warren
-
A regex match object's .end() value is already the index after the match,
not the index of the last character in the match, so there's no need to
add 1 to point past the match.Signed-off-by: Stephen Warren
-
Implement three improvements to the HTML log file:
- Ability to expand/contract sections. All passing sections are contracted
at file load time so the user can concentrate on issues requiring
action.
- The overall status report is copied to the top of the log for easy
access.
- Add links from the status report to the test logs, for easy navigation.This all relies on Javascript and the jquery library. If the user doesn't
have Javascript enabled, or jquery can't be downloaded, the log should
look and behave identically to how it did before this patch.A few notes on the diff:
- A few more 'with log.section("xxx")' were added, so that all stream
blocks are kept within a section block for consistent HTML entity
nesting structure. This changed indentation in a few places, making
the diff look slightly larger.
- HTML entity IDs are cleaned up. We assign simple incrementing integer
IDs now, rather than using mangled test names which were possibly
invalid.
- Sections and streams now use common CSS class names (in addition to the
current separate class names) to more easily share the new behaviour.
This also reduces the CSS file size since rules don't need to be
duplicated.
- An "OK" status is logged after some external command executions so that
make and flash steps are auto-contracted at log file load time, assuming
they passed.Signed-off-by: Stephen Warren
-
The test/py/test.py wrapper script catches exceptions thrown when
exec()ing py.test in order to print a helpful error message. However,
the exception handling code squashes the exception and so the script
exits with a non-zero exit code, leading callers to believe that it
passed. Fix this.Signed-off-by: Stephen Warren
08 Feb, 2016
1 commit
-
Implement command--line option --gdbserver COMM, which does two things:
a) Run the sandbox process under gdbserver, using COMM as gdbserver's
communication channel.b) Disables all timeouts, so that if U-Boot is halted under the debugger,
tests don't fail. If the user gives up in the middle of a debugging
session, they can simply CTRL-C the test script to abort it.This allows easy debugging of test failures without having to manually
re-create the failure conditions. Usage is:Window 1:
./test/py/test.py --bd sandbox --gdbserver localhost:1234Window 2:
gdb ./build-sandbox/u-boot -ex 'target remote localhost:1234'When using this option, it likely makes sense to use pytest's -k option
to limit the set of tests that are executed.Simply running U-Boot directly under gdb (rather than gdbserver) was
also considered. However, this was rejected because:a) gdb's output would then be processed by the test script, and likely
confuse it causing false failures.b) pytest by default hides stdout from tests, which would prevent the
user from interacting with gdb.While gdb can be told to redirect the debugee's stdio to a separate
PTY, this would appear to leave gdb's stdio directed at the test
scripts and the debugee's stdio directed elsewhere, which is the
opposite of the desired effect. Perhaps some complicated PTY muxing
and process hierarchy could invert this. However, the current scheme
is simple to implement and use, so it doesn't seem worth complicating
matters.c) Using gdbserver allows arbitrary debuggers to be used, even those with
a GUI. If the test scripts invoked the debugger themselves, they'd have
to know how to execute arbitary applications. While the user could hide
this all in a wrapper script, this feels like extra complication.An interesting future idea might be a --gdb-screen option, which could
spawn both U-Boot and gdb separately, and spawn the screen into a newly
created window under screen. Similar options could be envisaged for
creating a new xterm/... too.--gdbserver currently only supports sandbox, and not real hardware.
That's primarily because the test hooks are responsible for all aspects of
hardware control, so there's nothing for the test scripts themselves can
do to enable gdbserver on real hardware. We might consider introducing a
separate --disable-timeouts option to support use of debuggers on real
hardware, and having --gdbserver imply that option.Signed-off-by: Stephen Warren
06 Feb, 2016
1 commit
-
Close the file earlier to hopefully fix a Coverity error.
Reported-by: Coverity (CID: 134901)
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
30 Jan, 2016
4 commits
-
This adds tests for the different character types, line wrap, scrolling and
backspace.Signed-off-by: Simon Glass
-
Enable this feature so that truetype fonts can be used on the sandbox
console. Update the tests to select the normal/rotated console when needed.Signed-off-by: Simon Glass
Signed-off-by: Anatolij Gustschin -
This can be sent when to many characters are entered. Make sure it is
ignored and does not cause a character to be displayed.Signed-off-by: Simon Glass
-
With anti-aliased fonts we need a more fine-grained horizontal position
than a single pixel. Characters can be positioned to start part-way through
a pixel, with anti-aliasing (greyscale edges) taking care of the visual
effect.To cope with this, use fractional units (1/256 pixel) for horizontal
positions in the text console.Signed-off-by: Simon Glass
[agust: rebased]
Signed-off-by: Anatolij Gustschin
29 Jan, 2016
1 commit
-
Allow the env__dfu_configs boardenv data to specify the set of DFU
transfer sizes to test. Manually specifying test sizes is useful if you
wish to test multiple DFU configurations (e.g. SD card ext4 filesystem, SD
card whole raw partition, RAM, etc.), but don't want to test every
single transfer size on each, to avoid bloating the overall time taken by
testing. If the boardenv doesn't specify a set of sizes, the built-in list
is used as a default, preserving backwards-compatibility.Signed-off-by: Stephen Warren
Acked-by: Simon Glass