29 Sep, 2014
1 commit
-
There is no need to init .owner field.
Based on the patch from Peter Griffin
"mmc: remove .owner field for drivers using module_platform_driver"This patch removes the superflous .owner field for drivers which
use the module_platform_driver API, as this is overriden in
platform_driver_register anyway."Signed-off-by: Kiran Padwal
Reviewed-by: Ivan T. Ivanov
Signed-off-by: Greg Kroah-Hartman
24 Sep, 2014
1 commit
-
USB hub has started to use a workqueue instead of kthread. Let's update
the documentation and comments here and there.This patch mostly just replaces "khubd" with "hub_wq". There are only few
exceptions where the whole sentence was updated. These more complicated
changes can be found in the following files:Documentation/usb/hotplug.txt
drivers/net/usb/usbnet.c
drivers/usb/core/hcd.c
drivers/usb/host/ohci-hcd.c
drivers/usb/host/xhci.cSigned-off-by: Petr Mladek
Acked-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman
16 Sep, 2014
1 commit
-
Linux 3.17-rc5
Signed-off-by: Felipe Balbi
Conflicts:
Documentation/devicetree/bindings/usb/mxs-phy.txt
drivers/usb/phy/phy-mxs-usb.c
09 Sep, 2014
1 commit
-
Merge Linux 3.17-rc4 here so we have all the latest
fixes on next too. This also cleans up a few conflicts
when applying patches.Signed-off-by: Felipe Balbi
Conflicts:
drivers/usb/gadget/Makefile
drivers/usb/gadget/function/Makefile
drivers/usb/gadget/legacy/Makefile
drivers/usb/phy/phy-samsung-usb.h
03 Sep, 2014
2 commits
-
The PHY configuration is stored in an opaque "config" field, but when
allocating the structure, its proper size needs to be known. In the case
of UTMI, the proper structure is tegra_utmip_config of which a local
variable already exists, so we can use that to obtain the size from.Fixes the following warning from the sparse checker:
drivers/usb/phy/phy-tegra-usb.c:882:17: warning: expression using sizeof(void)
Fixes: 81d5dfe6d8b3 (usb: phy: tegra: Read UTMIP parameters from device tree)
Cc: stable@vger.kernel.org
Signed-off-by: Thierry Reding
Signed-off-by: Felipe Balbi -
Add imx6sx support
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
02 Sep, 2014
4 commits
-
It's not being used any longer.
Signed-off-by: Tony Lindgren
Signed-off-by: Felipe Balbi -
drivers/usb/phy/phy-samsung-usb[2,3] drivers got replaced by
drivers/phy/phy-samsung-usb[2,3] ones and the old common Samsung
USB PHY code is no longer used.Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Reviewed-by: Vivek Gautam
Reviewed-by: Jingoo Han
Acked-by: Kishon Vijay Abraham I
Cc: Kamil Debski
Signed-off-by: Felipe Balbi -
drivers/usb/phy/phy-samsung-usb3 driver got replaced by
drivers/phy/phy-samsung-usb3 one and is no longer used.Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Reviewed-by: Vivek Gautam
Reviewed-by: Jingoo Han
Acked-by: Kishon Vijay Abraham I
Cc: Kamil Debski
Signed-off-by: Felipe Balbi -
drivers/usb/phy/phy-samsung-usb2 driver got replaced by
drivers/phy/phy-samsung-usb2 one and is no longer used.Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Reviewed-by: Vivek Gautam
Reviewed-by: Jingoo Han
Acked-by: Kishon Vijay Abraham I
Cc: Kamil Debski
Signed-off-by: Felipe Balbi
28 Aug, 2014
2 commits
-
This patch makes the phy reset clk and reset line optional as this clk
is not available on boards like IFC6410 with APQ8064.phy-reset clk is only used as argument to the mach level callbacks, so
this patch adds condition before clk_get calls so that the driver
wouldn't fail on SOCs which do not have this support.Signed-off-by: Srinivas Kandagatla
Signed-off-by: Felipe Balbi -
This adds support for the USB PHY in Vybrid VF610. We assume that
the disconnection without VBUS is also needed for Vybrid.Tests showed, without MXS_PHY_NEED_IP_FIX, enumeration of devices
behind a USB Hub fails with errors:[ 215.163507] usb usb1-port1: cannot reset (err = -32)
[ 215.170498] usb usb1-port1: cannot reset (err = -32)
[ 215.185120] usb usb1-port1: cannot reset (err = -32)
[ 215.191345] usb usb1-port1: cannot reset (err = -32)
[ 215.202487] usb usb1-port1: cannot reset (err = -32)
[ 215.207718] usb usb1-port1: Cannot enable. Maybe the USB cable is bad?
[ 215.219317] usb usb1-port1: unable to enumerate USB deviceHence we also enable the MXS_PHY_NEED_IP_FIX flag.
Acked-by: Peter Chen
Signed-off-by: Stefan Agner
Signed-off-by: Felipe Balbi
21 Aug, 2014
2 commits
-
that declaration is only used inside this driver,
marking it static.Signed-off-by: Felipe Balbi
-
Remove unnecessary lines of register bit definitions in order
to enhance the readability. In this case, there are lines
per register offset definitions. There is no functional change.Signed-off-by: Jingoo Han
Signed-off-by: Felipe Balbi
19 Aug, 2014
4 commits
-
In case of error, the function devm_ioremap_nocache() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.Signed-off-by: Wei Yongjun
Signed-off-by: Felipe Balbi -
According to the datasheet, PHYPARAM1_PCS_TXDEEMPH is set as
6 bits [5:0]. Thus, the bit mask should be set as 0x3f, instead
of 0x1f.Signed-off-by: Jingoo Han
Signed-off-by: Felipe Balbi -
Using kfree to free data allocated with devm_kzalloc causes double frees.
The Coccinelle semantic patch that fixes this problem is as follows:
//
@@
expression x;
@@x = devm_kzalloc(...)
...
?-kfree(x);
//Reviewed-by: Jingoo Han
Acked-by: Julia Lawall
Signed-off-by: Himangi Saraogi
Signed-off-by: Felipe Balbi -
When __usb_find_phy_dev() does not return error and
try_module_get() fails, return -ENODEV.Signed-off-by: Arjun Sreedharan
Signed-off-by: Felipe Balbi
07 Aug, 2014
1 commit
-
Pull trivial tree changes from Jiri Kosina:
"Summer edition of trivial tree updates"* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (23 commits)
doc: fix two typos in watchdog-api.txt
irq-gic: remove file name from heading comment
MAINTAINERS: Add miscdevice.h to file list for char/misc drivers.
scsi: mvsas: mv_sas.c: Fix for possible null pointer dereference
doc: replace "practise" with "practice" in Documentation
befs: remove check for CONFIG_BEFS_RW
scsi: doc: fix 'SCSI_NCR_SETUP_MASTER_PARITY'
drivers/usb/phy/phy.c: remove a leading space
mfd: fix comment
cpuidle: fix comment
doc: hpfall.c: fix missing null-terminate after strncpy call
usb: doc: hotplug.txt code typos
kbuild: fix comment in Makefile.modinst
SH: add proper prompt to SH_MAGIC_PANEL_R2_VERSION
ARM: msm: Remove MSM_SCM
crypto: Remove MPILIB_EXTRA
doc: CN: remove dead link, kerneltrap.org no longer works
media: update reference, kerneltrap.org no longer works
hexagon: update reference, kerneltrap.org no longer works
doc: LSM: update reference, kerneltrap.org no longer works
...
22 Jul, 2014
1 commit
-
Felipe writes:
usb: patches for v3.17 merge window
Surprisingly enough, while a big set of patches, the majority is
composed of cleanups (using devm_*, fixing sparse errors, moving
code around, adding const, etc).The highlights are addition of new support for PLX USB338x devices,
and support for USB 2.0-only configurations of the DWC3 IP core.Signed-of-by: Felipe Balbi
10 Jul, 2014
4 commits
-
Use SIMPLE_DEV_PM_OPS macro and remove DEV_PM_OPS macro, in order
to make the code simpler.Acked-by: Roger Quadros
Signed-off-by: Jingoo Han
Signed-off-by: Felipe Balbi -
It is no longer needed and keeping it will break 64-bit ARM builds.
Signed-off-by: Thierry Reding
Signed-off-by: Felipe Balbi -
tegra_usb_phy_close() is supposed to undo the effects of
tegra_usb_phy_init(). It is also currently added as the USB PHY shutdown
callback, which is wrong, since tegra_usb_phy_init() is only called
during probing wheras the shutdown callback can get called multiple
times. This then leads to warnings about unbalanced regulator_disable if
the EHCI driver is unbound and bound again at runtime.Signed-off-by: Tuomas Tynkkynen
Acked-by: Mark Rutland
Signed-off-by: Greg Kroah-Hartman -
It is no longer needed and keeping it will break 64-bit ARM builds.
Signed-off-by: Thierry Reding
Signed-off-by: Greg Kroah-Hartman
01 Jul, 2014
5 commits
-
Use case is when the phy is configured in host mode and a usb device is
attached to board before bootup. On bootup, with the existing code and
runtime pm enabled, the driver would decrement the pm usage count
without checking the current state of the phy. This pm usage count
decrement would trigger the runtime pm which than would abort the
usb enumeration which was in progress. In my case a usb stick gets
detected and then immediatly the driver goes to low power mode which is
not correct.log:
[ 1.631412] msm_hsusb_host 12520000.usb: EHCI Host Controller
[ 1.636556] msm_hsusb_host 12520000.usb: new USB bus registered, assigned bus number 1
[ 1.642563] msm_hsusb_host 12520000.usb: irq 220, io mem 0x12520000
[ 1.658197] msm_hsusb_host 12520000.usb: USB 2.0 started, EHCI 1.00
[ 1.659473] hub 1-0:1.0: USB hub found
[ 1.663415] hub 1-0:1.0: 1 port detected
...
[ 1.973352] usb 1-1: new high-speed USB device number 2 using msm_hsusb_host
[ 2.107707] usb-storage 1-1:1.0: USB Mass Storage device detected
[ 2.108993] scsi0 : usb-storage 1-1:1.0
[ 2.678341] msm_otg 12520000.phy: USB in low power mode
[ 3.168977] usb 1-1: USB disconnect, device number 2This issue was detected on IFC6410 board.
This patch fixes the intial runtime pm trigger by checking the phy
state and decrementing the pm use count only when the phy state is IDLE.Signed-off-by: Srinivas Kandagatla
Signed-off-by: Felipe Balbi -
This patch makes the phy reset clk and reset line optional as this clk
is not available on boards like IFC6410 with APQ8064.Signed-off-by: Srinivas Kandagatla
Signed-off-by: Felipe Balbi -
The various devm_ functions allocate memory that is released when a
driver detaches. This patch uses devm_kzalloc, devm_request_irq,
devm_gpio_request, devm_regulator_get etc. for data that is
allocated in the probe function of a platform device and is only
freed in the remove function. The corresponding free functions are
removed and the labels are done away with.Signed-off-by: Himangi Saraogi
Acked-by: Julia Lawall
Signed-off-by: Felipe Balbi -
Make of_device_id array const, because all OF functions handle
it as const.Signed-off-by: Jingoo Han
Signed-off-by: Felipe Balbi -
Make of_device_id array const, because all OF functions handle
it as const.Signed-off-by: Jingoo Han
Signed-off-by: Felipe Balbi
19 Jun, 2014
1 commit
-
Signed-off-by: Antonio Ospite
Acked-by: Felipe Balbi
Signed-off-by: Jiri Kosina
04 Jun, 2014
1 commit
-
Pull USB driver updates from Greg KH:
"Here is the big USB driver pull request for 3.16-rc1.Nothing huge here, but lots of little things in the USB core, and in
lots of drivers. Hopefully the USB power management will be work
better now that it has been reworked to do per-port power control
dynamically. There's also a raft of gadget driver updates and fixes,
CONFIG_USB_DEBUG is finally gone now that everything has been
converted over to the dynamic debug inteface, the last hold-out
drivers were cleaned up and the config option removed. There were
also other minor things all through the drivers/usb/ tree, the
shortlog shows this pretty well.All have been in linux-next, including the very last patch, which came
from linux-next to fix a build issue on some platforms"* tag 'usb-3.16-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb: (314 commits)
usb: hub_handle_remote_wakeup() only exists for CONFIG_PM=y
USB: orinoco_usb: remove CONFIG_USB_DEBUG support
USB: media: lirc: igorplugusb: remove CONFIG_USB_DEBUG support
USB: media: streamzap: remove CONFIG_USB_DEBUG
USB: media: redrat3: remove CONFIG_USB_DEBUG usage
USB: media: redrat3: remove unneeded tracing macro
usb: qcserial: add additional Sierra Wireless QMI devices
usb: host: max3421-hcd: Use module_spi_driver
usb: host: max3421-hcd: Allow platform-data to specify Vbus polarity
usb: host: max3421-hcd: fix "spi_rd8" uses dynamic stack allocation warning
usb: host: max3421-hcd: Fix missing unlock in max3421_urb_enqueue()
usb: qcserial: add Netgear AirCard 341U
Documentation: dt-bindings: update xhci-platform DT binding for R-Car H2 and M2
usb: host: xhci-plat: add xhci_plat_start()
usb: host: max3421-hcd: Fix potential NULL urb dereference
Revert "usb: gadget: net2280: Add support for PLX USB338X"
USB: usbip: remove CONFIG_USB_DEBUG reference
USB: remove CONFIG_USB_DEBUG from defconfig files
usb: resume child device when port is powered on
usb: hub_handle_remote_wakeup() depends on CONFIG_PM_RUNTIME=y
...
03 Jun, 2014
1 commit
-
Pull ARM SoC board support updates from Olof Johansson:
"The bulk of this branch is updates for Renesas Shmobile. They are
still doing some enablement for classic boards first, and then come up
with DT bindings when they've had a chance to learn more about the
hardware. Not necessarily a bad way to go about it, and they're
looking at moving some of the temporary board code resulting from it
to drivers/staging instead to avoid the churn here.As a result of the shmobile clock cleanups, we end up merging quite a
bit of SH code here as well. We ended up merging it here instead of
in the cleanup branch due to the other board changes depending on it"* tag 'boards-for-3.16' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc: (130 commits)
ARM: davinci: remove checks for CONFIG_USB_MUSB_PERIPHERAL
ARM: add drivers for Colibri T30 to multi_v7_defconfig
ARM: shmobile: Remove Genmai reference DTS
ARM: shmobile: Let Genmai multiplatform boot with Genmai DTB
ARM: shmobile: Sync Genmai DTS with Genmai reference DTS
ARM: shmobile: genmai-reference: Remove legacy clock support
ARM: shmobile: Remove non-multiplatform Genmai reference support
ARM: configs: enable XHCI mvebu support in multi_v7_defconfig
ARM: OMAP: replace checks for CONFIG_USB_GADGET_OMAP
ARM: OMAP: AM3517EVM: remove check for CONFIG_PANEL_SHARP_LQ043T1DG01
ARM: OMAP: SX1: remove check for CONFIG_SX1_OLD_FLASH
ARM: OMAP: remove some dead code
ARM: OMAP: omap3stalker: remove two Kconfig macros
ARM: tegra: tegra_defconfig updates
ARM: shmobile: r7s72100: use workaround for non DT-clocks
ARM: shmobile: Add forward declaration of struct clk to silence warning
ARM: shmobile: r7s72100: remove SPI DT clocks from legacy clock support
ARM: shmobile: r7s72100: add spi clocks to dtsi
ARM: shmobile: r7s72100: remove I2C DT clocks from legacy clock support
ARM: shmobile: r7s72100: add i2c clocks to dtsi
...
28 May, 2014
3 commits
-
Signed-off-by: Liviu Dudau
Signed-off-by: Ryan Harkin
Signed-off-by: Mark Brown
Signed-off-by: Greg Kroah-Hartman -
Since usb otg fsm implementation is not related to usb phy.
We move it from usb/phy/ to usb/common/, and rename it to
reflect its real meaning.Cc: Felipe Balbi
Signed-off-by: Peter Chen
Signed-off-by: Greg Kroah-Hartman -
The Renesas R-Car USB PHY driver only supports the R8A7778 and
R8A7779, it isn't useful on other systems unless build testing.Signed-off-by: Jean Delvare
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: Laurent Pinchart
Signed-off-by: Greg Kroah-Hartman
23 May, 2014
2 commits
-
My previous patch introduced a bug which prevented this driver from
loading. devm_ioremap_resource() has a call to
devm_request_mem_region() which will fail because the address space is
shared between this PHY driver and CI device controller driver.Fixes: 10f0577aa5cb ('usb: phy: msm: change devm_ioremap() to devm_ioremap_resource()')
Reported-by:"Ivan T. Ivanov"
Signed-off-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman -
Felipe writes:
usb: patches for v3.16 merge window
Not a lot here during this merge window. Mostly we just have
the usual miscellaneous patches (removal of unnecessary prints,
proper dependencies being added to Kconfig, build warning fixes,
new device ID, etc.Other than those, the only important new features are the
new support for OS Strings which should help Linux Gadget
Drivers behave better under MS Windows. Also Babble Recovery
implementation for MUSB on AM335x. Lastly, we also have
ARCH_QCOM PHY support though phy-msm.Signed-of-by: Felipe Balbi
Conflicts:
drivers/usb/phy/phy-mv-u3d-usb.c
20 May, 2014
1 commit
-
We need these USB fixes in here as well.
Signed-off-by: Greg Kroah-Hartman
17 May, 2014
1 commit
-
Commit 193ab2a60700 ("usb: gadget: allow multiple gadgets to be built")
apparently required that checks for CONFIG_USB_GADGET_OMAP would be
replaced with checks for CONFIG_USB_OMAP. Do so now for the remaining
checks for CONFIG_USB_GADGET_OMAP, even though these checks have
basically been broken since v3.1.And, since we're touching this code, use the IS_ENABLED() macro, so
things will now (hopefully) also work if USB_OMAP is modular.Fixes: 193ab2a60700 ("usb: gadget: allow multiple gadgets to be built")
Signed-off-by: Paul Bolle
Signed-off-by: Tony Lindgren
15 May, 2014
1 commit
-
adding new device id for SMSC USB334x devices.
Signed-off-by: Liviu Dudau
Signed-off-by: Ryan Harkin
Signed-off-by: Mark Brown
Signed-off-by: Felipe Balbi