19 Feb, 2020
2 commits
-
The implementation of dma_map_single() and dma_unmap_single() is
exactly the same for all the architectures that support them.Factor them out to , and make all drivers to
include instead of .If we need to differentiate them for some architectures, we can
move the generic definitions to .Add some comments to the helpers. The concept is quite similar to
the DMA-API of Linux kernel. Drivers are agnostic about what is
going on behind the scene. Just call dma_map_single() before the
DMA, and dma_unmap_single() after it.Signed-off-by: Masahiro Yamada
-
dma_unmap_single() takes the dma address, not virtual address.
Signed-off-by: Masahiro Yamada
06 Feb, 2020
2 commits
-
At present dm/device.h includes the linux-compatible features. This
requires including linux/compat.h which in turn includes a lot of headers.
One of these is malloc.h which we thus end up including in every file in
U-Boot. Apart from the inefficiency of this, it is problematic for sandbox
which needs to use the system malloc() in some files.Move the compatibility features into a separate header file.
Signed-off-by: Simon Glass
-
At present devres.h is included in all files that include dm.h but few
make use of it. Also this pulls in linux/compat which adds several more
headers. Drop the automatic inclusion and require files to include devres
themselves. This provides a good indication of which files use devres.Signed-off-by: Simon Glass
Reviewed-by: Anatolij Gustschin
20 Jan, 2020
1 commit
-
AM654 has DWC3 USB controller that is very similar to other TI SoCs. Add
a new compatible to enable the same.Signed-off-by: Vignesh Raghavendra
Reviewed-by: Marek Vasut
Signed-off-by: Lokesh Vutla
22 Dec, 2019
1 commit
-
DWC3 support phy interfaces like 8/16-bit UTMI+. phy interface
initialization code would handle them properly along with UNKNOWN
type by default if none of the user/board doesn't need to use the
phy interfaces at all.The current code is masking the 8/16-bit UTMI+ interface bits globally
which indeed effect the UNKNOWN cases, therefore it effects the platforms
which are not using phy interfaces at all.So, handle the phy masking bits accordingly on respective interface
type cases.Fixes: 6b7ebff00190 ("usb: dwc3: Add phy interface for dwc3_uboot")
Reported-by: Andy Shevchenko
Signed-off-by: Jagan Teki
03 Dec, 2019
1 commit
-
These functions are CPU-related and do not use driver model. Move them to
cpu_func.hSigned-off-by: Simon Glass
Reviewed-by: Daniel Schwierzeck
Reviewed-by: Tom Rini
23 Nov, 2019
1 commit
-
U-Boot has two different variants of dwc3 initializations,
- with dm variant gadget, so the respective dm driver would
call the dwc3_init in core.
- with non-dm variant gadget, so the usage board file would
call dwc3_uboot_init in core.The driver probe would handle all respective gadget properties
including phy interface via phy_type property and then trigger
dwc3_init for dm-variant gadgets.So, to support the phy interface for non-dm variant gadgets,
the better option is dwc3_uboot_init since there is no
dedicated controller for non-dm variant gadgets.This patch support for adding phy interface like 8/16-bit UTMI+
code for dwc3_uboot.This change used Linux phy.h enum list, to make proper code
compatibility.Cc: Marek Vasut
Tested-by: Levin Du
Signed-off-by: Jagan Teki
Reviewed-by: Marek Vasut
Reviewed-by: Kever Yang
31 Oct, 2019
2 commits
-
Calling cache flush on invalid buffer, even with zero length might cause
an exception on certain platforms.Signed-off-by: Marek Szyprowski
-
Some boards don't populate clk/reset entries as these are are optional
as per binding documentation. Therefore, don't fail driver probe if
clk/reset entries are absent in DT.This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx
Fixes: e8e683d33b0c ("board: ti: am57xx-idk: Configure the CDCE913 clock synthesizer")
Reported-by: Sam Protsenko
Signed-off-by: Vignesh Raghavendra
24 Oct, 2019
8 commits
-
The mode selection for the DWC3 is kind of obsolete. The driver does not
have to be host only or gadget only. This choice is confusing.
All the remaining callers of dwc3_uboot_init() explicitly set dr_mode
before calling the function, so none rely on a default behavior.Remove the choice menu and keep only the USB_DWC3_GADGET option. Enable it
by default if USB_GADGET and USB_DWC3 are enabled.
It must be disabled for the evb-rk3328 as it uses DWC2 for the gadget and
DWC3 for the host.Signed-off-by: Jean-Jacques Hiblot
-
Add a new function that read quirk and configuration information from the
DT. The goal is to allow platforms using their own version of DWC3 driver
to migrate to the generic DWC3 driver.
The function is adapted from the function dwc3_get_properties() in the
linux dwc3 driver introduced in commit c5ac6116db35d.Signed-off-by: Jean-Jacques Hiblot
-
There is no need to fail if the maximum speed is not specified.
If the speed is not specified, do the same as linux and assume super speed.Signed-off-by: Jean-Jacques Hiblot
-
Currently the host driver used by dwc3-generic is "xhci-dwc3". This is
a functional driver but it doesn't use the dwc3 core and, in particular,
it lacks some bits that may be important.
For example on the k2 platforms, it is important that the phy are properly
suspended when the USB is not used anymore. The dwc3 core also has a
partial support for quirks.
The new driver can be used as a drop-in replacement for "xhci-dwc3".In terms of implementation, it may seem strange that 2 private structures
dwc3_generic_host_priv and dwc3_generic_priv) are used. The reason for this
is simply that the xhci layer expects a struct xhci_ctrl at the beginning
of the private data and it seemed wasteful to include it also for the
peripheral case.Signed-off-by: Jean-Jacques Hiblot
-
Factor code for re-usability.
This is another step toward adding host support.Signed-off-by: Jean-Jacques Hiblot
-
Separate platform data from the private data.
This is one step toward adding host support.Signed-off-by: Jean-Jacques Hiblot
-
No one is actually implementing those functions.
We could remove calls to these altogether, but it does not really hurt to
keep the empty inlined version at the moment and it satisfies a symmetry
with the gadget mode.Signed-off-by: Jean-Jacques Hiblot
-
This allow the phy to enter idle and then suspend.
the K2 platforms require the PHY to be suspended before the USB domain
clock can be turned off.Signed-off-by: Jean-Jacques Hiblot
08 Oct, 2019
1 commit
-
Phy setup should be done before dwc3 soft core reset as it is done
in linux & this fixes unreliable detection of usb cable on host side.Signed-off-by: T Karthik Reddy
Signed-off-by: Siva Durga Prasad Paladugu
Signed-off-by: Michal Simek
05 Jul, 2019
2 commits
-
dwc3-generic has been broken since MISC uclass has been modified to scan DT
sub-nodes after bind.
Fixing it by a using the no-op uclass.Signed-off-by: Jean-Jacques Hiblot
Reviewed-by: Simon Glass -
There is simply no reason to do that here.
Signed-off-by: Jean-Jacques Hiblot
09 May, 2019
1 commit
-
Adds support for Amlogic G12A USB Control Glue HW.
The Amlogic G12A SoC Family embeds 2 USB Controllers :
- a DWC3 IP configured as Host for USB2 and USB3
- a DWC2 IP configured as Peripheral USB2 OnlyA glue connects these both controllers to 2 USB2 PHYs, and optionnally
to an USB3+PCIE Combo PHY shared with the PCIE controller.The Glue configures the UTMI 8bit interfaces for the USB2 PHYs, including
routing of the OTG PHY between the DWC3 and DWC2 controllers, and
setups the on-chip OTG mode selection for this PHY.This driver sets the OTG capable port as Host mode by default,
the switch to Device mode is to be done in a separate patch.Signed-off-by: Neil Armstrong
Reviewed-by: Marek Vasut
15 Dec, 2018
3 commits
-
Signed-off-by: Jean-Jacques Hiblot
Reviewed-by: Tom Rini -
Signed-off-by: Jean-Jacques Hiblot
Reviewed-by: Tom Rini -
The BITMAP related operations can now be moved to ./include/linux/bitmap.h
file to mimic the Linux kernel directory tree.This change also allows to remove the lin_gadget_compat.h header file
(which is a legacy code only for composite U-boot layer).
It was also possible to remove #includes from several USB gadget drivers.Signed-off-by: Lukasz Majewski
Reviewed-by: Stefan Agner
07 Dec, 2018
9 commits
-
Signed-off-by: Jean-Jacques Hiblot
-
The error is:
In file included from include/part.h:10:0,
from include/usb.h:18,
from include/linux/usb/gadget.h:22,
from drivers/usb/dwc3/ep0.c:20:
include/ide.h:62:14: error: unknown type name ‘uchar’
void ide_led(uchar led, uchar status);Fixing it by including common.h that defines the uchar type.
Signed-off-by: Jean-Jacques Hiblot
-
The select_dr_mode operation is executed when the glue driver is probed.
The role of this optional function is to configure the operating mode
of the controller at the glue level.Signed-off-by: Jean-Jacques Hiblot
-
This make the driver more generic. At this point this driver can replace
the dwc3-of-simple implementation.
Make the description in the Kconfig more generic too.Signed-off-by: Jean-Jacques Hiblot
-
UCLASS_USB_DEV_GENERIC was meant for USB devices connected to host
controllers, not gadget devices.
Adding a new UCLASS for gadget devices alone.Also move the generic DM code for USB gadgets in a separate file for
clarity.Signed-off-by: Jean-Jacques Hiblot
-
Those operations can be used for peripheral operation as well as host
operation.Signed-off-by: Jean-Jacques Hiblot
# Conflicts:
# drivers/usb/dwc3/core.c
# drivers/usb/host/xhci-dwc3.c -
The driver will be probed when usb_gadget_initialize() is called.
Signed-off-by: Jean-Jacques Hiblot
-
When DM_USB_GADGET the platform code for the USB device must be replaced by
calls to a USB device driver.usb_gadget_initialize() probes the USB device driver.
usb_gadget_release() removes the USB device driver.Signed-off-by: Jean-Jacques Hiblot
Reviewed-by: Lukasz Majewski -
Using CONFIG_DM_USB for this purpose prevents using DM_USB for host and not
for device.Signed-off-by: Jean-Jacques Hiblot
Reviewed-by: Lukasz Majewski
27 Nov, 2018
1 commit
-
This allows to disable the USB driver model in SPL because it checks
the CONFIG_SPL_DM_USB variable for SPL builds. Nothing changes for
regular non-SPL builds.Signed-off-by: Sven Schwermer
28 Oct, 2018
1 commit
-
Complete in the drivers directory the work started with
commit 83d290c56fab ("SPDX: Convert all of our single
license tags to Linux Kernel style").Reviewed-by: Simon Glass
Signed-off-by: Patrick Delaunay
08 Jun, 2018
1 commit
-
Add WARN_ONCE definition to allow single time notification
of warnings to the user.
Taken from Linux kernel (4.17) with slight changes
(Removed __section(.data.once))Signed-off-by: Ramon Fried
[trini: Drop the musb and dwc3 compat versions]
Signed-off-by: Tom Rini
18 May, 2018
3 commits
-
devm_zalloc() is already defined in dm/device.h header, so
devm_zalloc can be removed from linux_compact.h beader file.Signed-off-by: Mugunthan V N
Signed-off-by: Michal Simek -
By enabling BLK by default this is the next driver which needs to get
support for DM_USB. Adding generic DWC3 glue logic which only
parse nodes and read device mode. Based on it probe proper
host/peripheral DWC3 drivers for it.Signed-off-by: Michal Simek
-
The patch is preparing dwc3 core for enabling DM_USB with peripheral
driver with using driver model support.
The driver will be bound by the DWC3 wrapper driver based on the
dr_mode device tree entry.Signed-off-by: Mugunthan V N
(Remove dwc3-omap changes)
Signed-off-by: Michal Simek
